Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credentials validation and required field notice for Payfast in sandbox environment. #260

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

iamdharmesh
Copy link
Member

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

This PR adds credentials validation in the Payfast payment settings when the settings are saved and displays a corresponding notice. It also makes changes to show a required credentials field notice when the credentials are blank, and it prevents Payfast from appearing on the front-end checkout page. Previously, this required notice was only implemented for the production environment. This PR ensures it works for the sandbox environment as well.

Closes #216

Steps to test the changes in this Pull Request:

  1. Remove all Payfast credentials from the settings and save the settings.
  2. Verify that a notice with the required fields error is visible.
  3. Try saving invalid credentials and verify that the merchant is prompted with an invalid credentials error.

Changelog entry

Add - Credentials validation and required field notice for Payfast in the sandbox environment

@iamdharmesh iamdharmesh self-assigned this Oct 1, 2024
@iamdharmesh iamdharmesh added this to the Future Release milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credential validation
2 participants