Fix PDF Credit Note Generation Crash by WC_Order
check
#411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR fixes a critical issue where the Square plugin's
filter_order_item_totals
function causes fatal errors when generating PDF credit notes with third-party PDF invoice plugins.The
filter_order_item_totals
function assumes the$order
parameter is always aWC_Order
object and calls$order->get_payment_method()
without validation. However, when generating credit notes, PDF plugins pass aWC_Order_Refund
object, which doesn't have theget_payment_method()
method, causing a fatal error.Closes https://linear.app/a8c/issue/SQUARE-180/square-plugin-crashes-pdf-credit-note-generation-for-3pd-plugin.
Steps to test the changes in this Pull Request:
I wasn’t able to reproduce the issue myself, but the fix is straightforward and non-harmful. Here are the steps that may help reproduce the issue and confirm the fix.
Setup Test Environment:
Test Regular PDF Generation:
Changelog entry