Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP version < 7.1 #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Drop support for PHP version < 7.1 #43

wants to merge 2 commits into from

Conversation

okonomi
Copy link
Member

@okonomi okonomi commented Oct 7, 2018

For next major version, I want to drop supporting PHP 7.0 or lower.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.06%) to 97.527% when pulling 5014787 on php71 into 8b7d9f5 on master.

@okonomi okonomi requested a review from yuya-takeyama October 7, 2018 05:04
@mimmi20
Copy link

mimmi20 commented Oct 7, 2018

ex) short array syntax, return type declarations, etc.

Does hhvm support these features?

@okonomi
Copy link
Member Author

okonomi commented Oct 7, 2018

@mimmi20 good point! I was missing considering hhvm compatibility...

"short array syntax" and "return type declarations" are ordinary syntax in today's PHP.
In hhvm official website, hhvm seems to support the major features of PHP 7, so probably we can use that.

But I do not know much about hhvm. I am going to experiment once about this subject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants