-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions for CI #51
base: master
Are you sure you want to change the base?
Conversation
@zonuexe |
.github/workflows/ci.yaml
Outdated
|
||
on: | ||
pull_request: | ||
branches: '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be **
because the branch name includes /
:
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
*: Matches zero or more characters, but does not match the / character.
Or I guess you can just omit it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuya-takeyama
Thank you. I'll fix it.
This change is actually based on the work of @tagomoris. woothee/woothee-js#21
Thanks. It must be approved by the maintainer in order to perform actions from outside contributors. |
3abc5ad
to
939f21f
Compare
Co-authored-by: Yuya Takeyama <sign.of.the.wolf.pentagram@gmail.com>
Just to test woothee/woothee-php#51
.github/workflows/ci.yaml
Outdated
- 'release-*' | ||
|
||
jobs: | ||
mri: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is not an intentional naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Fixed 9c9fd3f
Co-authored-by: Yuya Takeyama <sign.of.the.wolf.pentagram@gmail.com>
Hmm, still the approval button for GitHub Actions Workflow are not shown… ref: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks |
I opened this Pull Request to test the workflow: Some jobs failed, but the Workflow itself was triggered successfully. I am asking GitHub support about it The message I've sent to GitHub supportProblem"Approve and run" button is not shown in a Pull Request: Background
I'm following this documentation and everything looks fine: Is there anything I need to do for showing the approval button? |
Response from GitHub support:
|
Another response from GitHub support:
Let me try closing and reopening this Pull Request. |
@zonuexe |
No description provided.