Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions for CI #51

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

zonuexe
Copy link
Contributor

@zonuexe zonuexe commented Sep 20, 2021

No description provided.

@yuya-takeyama
Copy link
Member

@zonuexe
I'm wondering why this isn't triggered.
Is there anything I can help you with?


on:
pull_request:
branches: '*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be ** because the branch name includes /:
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

*: Matches zero or more characters, but does not match the / character.

Or I guess you can just omit it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuya-takeyama
Thank you. I'll fix it.
This change is actually based on the work of @tagomoris. woothee/woothee-js#21

@zonuexe
Copy link
Contributor Author

zonuexe commented Sep 20, 2021

@zonuexe
I'm wondering why this isn't triggered.
Is there anything I can help you with?

Thanks. It must be approved by the maintainer in order to perform actions from outside contributors.

Co-authored-by: Yuya Takeyama <sign.of.the.wolf.pentagram@gmail.com>
yuya-takeyama added a commit to yuya-takeyama/github-actions-sandbox that referenced this pull request Sep 25, 2021
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
- 'release-*'

jobs:
mri:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is not an intentional naming.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed 9c9fd3f

zonuexe and others added 2 commits September 26, 2021 04:14
Co-authored-by: Yuya Takeyama <sign.of.the.wolf.pentagram@gmail.com>
@yuya-takeyama
Copy link
Member

yuya-takeyama commented Sep 26, 2021

Hmm, still the approval button for GitHub Actions Workflow are not shown…

image

ref: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

@yuya-takeyama
Copy link
Member

I opened this Pull Request to test the workflow:
#53

Some jobs failed, but the Workflow itself was triggered successfully.
So, we have confirmed that there is no problem with the Workflow definition or syntax.

I am asking GitHub support about it

The message I've sent to GitHub support

Problem

"Approve and run" button is not shown in a Pull Request:
#51

Background

I'm following this documentation and everything looks fine:
https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

Is there anything I need to do for showing the approval button?

@yuya-takeyama
Copy link
Member

Response from GitHub support:

I was not able to figure out why this happened, everything seems configured properly. I have reached out to the engineering team to further investigate.

I'll let you know as soon as I hear back from the team.

@yuya-takeyama
Copy link
Member

Another response from GitHub support:

Thank you for your patience while the team looked into this.

I've been updated that this issue was caused because Actions workflows won't start triggering until Actions is installed on a repository - this is usually done by pushing a workflow to the repository or interacting with some Actions settings pages (like adding a new self-hosted runner).

A pull request from a fork won't be able to install Actions on a repository, so workflows from that PR won't trigger until Actions is installed.

As at when #51 was made, Actions was not installed in the repository.

However, when you opened #53, It installed actions.

Now that Actions is installed, any commits to #51 should trigger that pull request workflow. Closing and reopening the pull request should also work.

I hope this helps, please let us know if you need any further assistance.

Let me try closing and reopening this Pull Request.

@yuya-takeyama
Copy link
Member

@zonuexe
Finally, the Workflow is triggered.
But some tests are failing.
Would you check them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants