코드 리뷰용 pull request입니다. #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 22, 2023 02:41
added 15 commits
October 25, 2023 13:00
mouse0429
reviewed
Nov 4, 2023
|
|
||
| private fun validateBallNumber(ballNumber: Int) { | ||
| if (ballNumber < MIN_BALL_NUMBER || ballNumber > MAX_BALL_NUMBER) { | ||
| throw IllegalArgumentException("BallNumber는 1~9 사이의 숫자만 가능합니다.") |
There was a problem hiding this comment.
[Nit]
진짜 사소하지만...!!! MIN_BALL_NUMBER 와 MAX_BALL_NUMBER 를 상수화 해두셨으니 에러 메세지에도 적용되면 좋을 것 같습니다!
Comment on lines
+5
to
+6
| const val DEFAULT_START_INCLUSIVE = 1 | ||
| const val DEFAULT_END_INCLUSIVE = 9 |
There was a problem hiding this comment.
[IMHO]
MIN_BALL_NUM, MAX_BALL_NUM 와 같은 용도의 상수라 둘을 하나로 통일시키는 것도 좋았을 것 같습니다!
Comment on lines
+10
to
+32
| override fun render(): String { | ||
| if (gameResult.ballCount + gameResult.strikeCount == 0) { | ||
| return Hint.NOTHING.value | ||
| } | ||
| return listOf( | ||
| renderHint(Hint.BALL, gameResult.ballCount), | ||
| renderHint(Hint.STRIKE, gameResult.strikeCount), | ||
| ).joinToString(" ") | ||
| .trim() + | ||
| LINE_BREAK | ||
| } | ||
|
|
||
| private fun renderHint(hint: Hint, count: Int) = | ||
| when (count) { | ||
| 0 -> EMPTY | ||
| else -> "$count${hint.value}" | ||
| } | ||
|
|
||
| companion object { | ||
| const val EMPTY = "" | ||
| const val LINE_BREAK = "\n" | ||
| } | ||
| } |
There was a problem hiding this comment.
[LGTM]
코드리뷰를 많이하진 않았지만 처음 보는 방식이라 너무 신선했고 class를 잘 활용하시다는 느낌을 받았습니다! 한 수 배워갑니다!
Comment on lines
+5
to
+7
| class Reader { | ||
| fun readLine() = Console.readLine().trim() | ||
| } |
There was a problem hiding this comment.
[IMHO]
readline 을 InputView 에서도 한 번 재정의 하셨는데 Reader 클래스의 메소드로 또 재정의 하신 것 같아요!
한 번 재정의한 걸 반복적으로 사용하실 수 있도록 했어도 좋았을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.