refactor: 토글 UI 제거 및 낙관적 업데이트 적용 #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
getQuery로 현재 토큰을 받아오는 로직을 제거하고 mutation 내부에서 token을 받도록 로직 변경. 그 과정에서 token이 null이라면 에러를 던지도록 설정
데이터를 미리 fetch하지 않기 때문에 사이드 이펙트가 발생할 확률이 줄어들었습니다.
단 토큰을 받을때 마다 약 1~2초 사이의 간격이 발생하는데 해당 UI를 낙관적 업데이트를 통해 일단은 되도록 설정헀습니다.
추가적으로 PushStatus에 있는 불필요한 프로퍼티를 제거했습니다