Fix Allocator issues reported by ReSharper #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WSSDude
commented
Jan 12, 2025
•
WSSDude
commented
- missing template keyword calling dependent function name
- missing default initialization for AllocationResult
- disable ReSharper virtual destructor check
- reformat
- remove deprecated structs
psiberx
reviewed
Jan 12, 2025
WSSDude
force-pushed
the
feature/allocator-changes
branch
2 times, most recently
from
c28ee69 to
fcee988
Compare
WSSDude
force-pushed
the
feature/allocator-changes
branch
from
fcee988 to
2f085c1
Compare
wopss
reviewed
Jan 12, 2025
- missing template keyword calling dependent function name - missing default initialization for AllocationResult - disable ReSharper virtual destructor check - reformat - remove deprecated structs
WSSDude
force-pushed
the
feature/allocator-changes
branch
from
2f085c1 to
855ba85
Compare
psiberx
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.