Migrate HttpURLConnection usages to OkHttp
#22375
Merged
+101
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace direct HttpURLConnection usage with the shared OkHttpClient for
better connection pooling and consistency with the rest of the codebase.
Changes:
- Inject `@Named("regular") OkHttpClient` via Dagger
- Use HEAD request instead of GET for efficiency (only need Content-Length)
- Simplify content length retrieval using OkHttp's response API
Replace direct HttpURLConnection usage with the shared OkHttpClient for
video downloads in support ticket attachments.
Changes:
- Inject `@Named("regular") OkHttpClient` via Dagger
- Use `okHttpClient.newBuilder()` to configure custom timeouts
- Stream response body to temp file using OkHttp's byteStream API
- Simplify cleanup by relying on OkHttp's response.use {} auto-close
Replace direct HttpURLConnection usage with the shared OkHttpClient for
intercepting private site image requests in WebViews.
Changes:
- Inject `@Named("regular") OkHttpClient` via Dagger field injection
- Use synchronous `execute()` as required by `shouldInterceptRequest`
- Configure timeouts via `newBuilder()` to preserve existing behavior
- Pass response body stream directly to WebResourceResponse
Replace direct HttpURLConnection usage with the shared OkHttpClient for
intercepting private post image requests in Reader WebViews.
Changes:
- Inject `@Named("regular") OkHttpClient` in ReaderWebView
- Pass OkHttpClient to inner ReaderWebViewClient class
- Use synchronous `execute()` as required by `shouldInterceptRequest`
- Preserve User-Agent and Connection headers from original implementation
Collaborator
Generated by 🚫 Danger |
|
Contributor
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22375-3749bba | |
| Commit | 3749bba | |
| Direct Download | wordpress-prototype-build-pr22375-3749bba.apk |
Contributor
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22375-3749bba | |
| Commit | 3749bba | |
| Direct Download | jetpack-prototype-build-pr22375-3749bba.apk |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WordPress/src/main/java/org/wordpress/android/ui/reader/views/ReaderWebView.java
Dismissed
Show dismissed
Hide dismissed
WordPress/src/main/java/org/wordpress/android/ui/reader/views/ReaderWebView.java
Dismissed
Show dismissed
Hide dismissed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #22375 +/- ##
==========================================
- Coverage 39.02% 39.02% -0.01%
==========================================
Files 2203 2203
Lines 106342 106351 +9
Branches 15061 15061
==========================================
Hits 41501 41501
- Misses 61350 61359 +9
Partials 3491 3491 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adalpari
reviewed
Dec 1, 2025
|
|
||
| class TempAttachmentsUtil @Inject constructor( | ||
| @Named(IO_THREAD) private val ioDispatcher: CoroutineDispatcher, | ||
| @Named("regular") private val okHttpClient: OkHttpClient, |
Contributor
There was a problem hiding this comment.
❓ Can we use a constant here? There are 4 instances of "regular" in the PR
Contributor
Author
There was a problem hiding this comment.
I've looked at the same thing while reviewing the changes and found that this is extensively used across the code base. So, introducing a constant would need to be done in a separate PR - or we'd either introduce inconsistency or change too many irrelevant files.
adalpari
approved these changes
Dec 1, 2025
Contributor
adalpari
left a comment
adalpari
left a comment
There was a problem hiding this comment.
LGTM and works as expected!
Just left a minor comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate remaining
HttpURLConnectionusages toOkHttpfor consistency with the rest of the codebase. Using the sharedOkHttpClientprovides unified configuration, better connection pooling, and consistent timeout/auth handling.Changes
VideoLoader: Use OkHttp HEAD request to fetch video Content-Length headerTempAttachmentsUtil: Use OkHttp for downloading video attachments in support ticketsWPWebViewClient: Use OkHttp for intercepting private site image requests in WebViewsReaderWebView: Use OkHttp for intercepting private post image requests in ReaderTest Instructions