RS Post Settings: Add editable status, password, and sticky fields#22670
Open
RS Post Settings: Add editable status, password, and sticky fields#22670
Conversation
Adds the ability to edit post status (via dialog), password (via dialog), and sticky toggle in the RS post settings screen. Includes save functionality with network validation, discard confirmation dialog, and floating save button. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pre-populate password dialog with current value, add visibility toggle, finish screen on successful save instead of reloading, and show server error messages on save failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Finish the settings screen on successful save and return RESULT_OK so the post list refreshes all initialized tabs to reflect changes. Also show the server error message on save failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace floating back and save buttons with standard TopAppBar navigation icon and action button for a more consistent UI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ons" This reverts commit ccaedbb.
Remove the dark circle background from the floating back and save buttons so they use standard Material icon styling while remaining overlaid on the hero image. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Hide the status bar so the hero image and back/save icons extend to the very top of the screen. The status bar can be temporarily revealed with a swipe from the top edge. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use takeIf for edited field comparisons, collapse duplicate password and slug rows, remove unused save_success string, condense createIntent formatting, and clean up stray blank line in preview. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename PostFetchException to PostApiException, remove unnecessary WrongConstant suppression, unify back navigation through ViewModel, and add dedicated discard dialog strings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
…tus-password-sticky
Contributor
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WordPress/src/main/java/org/wordpress/android/ui/postsrs/screens/PostRsSettingsScreen.kt
Fixed
Show fixed
Hide fixed
Contributor
|
|
Extract savePost() from onSaveClicked() to fix LongMethod, reorder SettingsRow modifier parameter to fix ModifierParameter lint, and add gradient scrim behind floating icons for readability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevents Android from showing saved password suggestions in the post password dialog by setting IMPORTANT_FOR_AUTOFILL_NO_EXCLUDE_DESCENDANTS on the view while the dialog is visible. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #22670 +/- ##
==========================================
- Coverage 38.01% 37.92% -0.10%
==========================================
Files 2268 2268
Lines 116720 117000 +280
Branches 16180 16216 +36
==========================================
Hits 44376 44376
- Misses 68707 68987 +280
Partials 3637 3637 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostUpdateParamsAPI with server error passthroughTest plan
Screen_recording_20260309_162203.mp4