Fix x not in list error in memory websocket manager (#368)

* Fix x not in list error in memory websocket manager * Fix incorrect if in close of memory ws manager
workfloworchestrator · Oct 2, 2023 · fbd52e7 · fbd52e7
1 parent df326f3
commit fbd52e7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/orchestrator/websocket/managers/memory_websocket_manager.py b/orchestrator/websocket/managers/memory_websocket_manager.py
@@ -68,9 +68,9 @@ async def broadcast_data(self, channels: List[str], data: Dict) -> None:
     async def remove_ws(self, websocket: WebSocket, channel: str) -> None:
         if websocket.client_state != WebSocketState.DISCONNECTED:
             await self.disconnect(websocket)
-        if channel in self.connections_by_pid:
+        if channel in self.connections_by_pid and websocket in self.connections_by_pid[channel]:
             self.connections_by_pid[channel].remove(websocket)
-            if len(self.connections_by_pid[channel]):
+            if not len(self.connections_by_pid[channel]):
                 del self.connections_by_pid[channel]
         self.log_amount_of_connections()