-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the concept of known EventGroup metadata types. #1512
Conversation
5a84e21
to
2434820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 10 files at r1, all commit messages.
Reviewable status: 9 of 10 files reviewed, all discussions resolved
2434820
to
56e626e
Compare
This was significantly reworked to account for the fact that some metadata message types should be shared. One example is SyntheticEventGroupSpec. PTAL. Depends on world-federation-of-advertisers/common-jvm#235 CC @robinsons |
56e626e
to
ce8facb
Compare
d24e8e7
to
2b26256
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the use case for sharing metadata messages?
Reviewed 19 of 59 files at r2, 1 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: 29 of 68 files reviewed, all discussions resolved
22fa87d
to
33ff31e
Compare
2b26256
to
56f32f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We use shared metadata message types for the simulator test event groups
- A given market may want all EventGroups across all EDPs to have a field with some common message type
Reviewable status: 29 of 68 files reviewed, all discussions resolved (waiting on @stevenwarejones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Will this be the case? EDPs probably use different taxonomies and will need different event group metadata.
Reviewable status: 29 of 68 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A field with a common message type is not the whole message type. Basically the metadata can have a common part and an EDP-specific part. IIUC, having some commonality is a desire that has already been expressed by Origin.
Reviewable status: 29 of 68 files reviewed, all discussions resolved (waiting on @stevenwarejones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 38 of 59 files at r2, 1 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
56f32f9
to
8f0e67a
Compare
33ff31e
to
f8918a7
Compare
8f0e67a
to
d60aaed
Compare
a813002
to
69baa4c
Compare
f85b958
to
49d33b3
Compare
69baa4c
to
b426714
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
49d33b3
to
49cdf6c
Compare
b426714
to
cf321bf
Compare
49cdf6c
to
4809980
Compare
Known types are types expected to be known by all callers. These need not be included in the EventGroupMetadataDescriptor FileDescriptorSet, and are instead loaded separately. This also enforces uniqueness for EventGroupMetadataDescriptor message types. Note that this only affects the creation of new resources. Existing resources may exist that already violate this constraint.
4809980
to
83f6ac4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r6.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
Known EventGroup metadata types are types expected to be known by all callers. These need not be included in the EventGroupMetadataDescriptor FileDescriptorSet, and are instead loaded separately. This also enforces uniqueness for EventGroupMetadataDescriptor message types. Note that this only affects the creation of new resources. Existing resources may exist that already violate this constraint. Includes a workaround for bazelbuild/rules_proto#203. Closes #1511
Known EventGroup metadata types are types expected to be known by all callers. These need not be included in the EventGroupMetadataDescriptor FileDescriptorSet, and are instead loaded separately.
This also enforces uniqueness for EventGroupMetadataDescriptor message types. Note that this only affects the creation of new resources. Existing resources may exist that already violate this constraint.
Includes a workaround for bazelbuild/rules_proto#203.
Closes #1511