-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up GitHub Actions #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elbeejay Thank you for opening this PR. While this testing workflow can go in parallel, I'd recommend migrating to pyproject.toml
first (#40 and #41), including the dependencies and optional dependencies. For example, in the new setup, the dependencies can be added and pinned and the installation could be simplified to pip install gostnets
or pip install "gostnets[optimization]"
(or even include all dependencies by default because they are not large). Then this PR can be updated and merged. What are your thoughts?
Additionally, the documentation, tests and release workflow (e.g., BlackMarblePy) can also be prioritized. If you agree with the course of action, could you please create and prioritize these as tasks?
Sure, I'd just started here because the PEP stuff wasn't clear to me (from here) but now that we've cleared that up I can set up the |
Added a "publish" workflow for automatic publishing to pypi. May requre configuration on the pypi side per this document |
* add basic ci/cd workflow to test install * fix location of actions workflow * fix matrix for os and python version * print conda python version * Update build.yml * python3.8 for ci * use local pip install for cicd * add publish workflow
@elbeejay Thanks! Merging (we can open other PRs to complement this basic setip). FYI I have requested a |
Set up some GitHub actions starting with a simple continuous integration workflow to try installing the
GOSTnets
package on the 3 major operating systems (Linux, Windows, MacOS) for Python 3.8 and then runningPython -c import GOSTnets
as a very basic test of the package having installed and existing.Right now we are limited to Python 3.8 because of the hard-pinned dependency
rtree-0.9.3
per the project's readme.