feat: store metadata in S3 metadata instead of separate object #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolodamico
requested review from
aurel-fr,
murph and
thomas-waite
as code owners
Contributor
Author
|
Requires #101 to be merged first |
aurel-fr
approved these changes
Sep 6, 2025
| .bucket(self.environment.s3_bucket()) | ||
| .key(get_metadata_key(&backup_metadata.id)) | ||
| .body(ByteStream::from(serde_json::to_vec(backup_metadata)?)) | ||
| .metadata("backup-metadata", compressed_metadata) |
Contributor
There was a problem hiding this comment.
the optional user-defined metadata names must begin with x-amz-meta- to distinguish them from other HTTP headers
| let compressed_metadata = result | ||
| .metadata | ||
| .as_ref() | ||
| .and_then(|m| m.get("backup-metadata")) |
Contributor
There was a problem hiding this comment.
This string is throughout the file, it would be better as a constant.
|
|
||
| let encoded_meta = BASE64_STANDARD.encode(&compressed); | ||
|
|
||
| if encoded_meta.len() > 2000 { |
Contributor
There was a problem hiding this comment.
the 2Kb is inclusive of the size of the key, it must be accounted for here too.
Contributor
Author
|
leaving this for a later stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores metadata as S3 metadata object instead of as a separate object in the bucket.
The metadata has a size limit of 2KB. To better accommodate this, the PR:
Why?
Enables atomic updates of the backup and metadata.