fix proof packing/unpacking #1239
Merged
+57
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
requested review from
andy-t-wang and
michalstruck
as code owners
decentralgabe
temporarily deployed
to
development
GitHub Actions
Inactive
decentralgabe
temporarily deployed
to
development
GitHub Actions
Inactive
andy-t-wang
approved these changes
Mar 14, 2025
decentralgabe
force-pushed
the
try-again
branch
from
361ac40 to
f785c72
Compare
decentralgabe
temporarily deployed
to
development
GitHub Actions
Inactive
![semgrep-code-worldcoin[bot]](https://avatars.githubusercontent.com/u/60940476?s=60&v=4){kind=small}
web/pnpm-lock.yaml
Outdated
| @@ -5587,6 +5726,14 @@ packages: | |||
| snake-case@3.0.4: | |||
| resolution: {integrity: sha512-LAOh4z89bGQvl9pFfNF8V146i7o7/CqFPbqzYgP+yYzDIDeS9HaNFtXABamRW+AQzEVODcvE79ljJ+8a9YSdMg==} | |||
|
|
|||
| snarkjs@0.4.16: | |||
There was a problem hiding this comment.
~~Risk: snarkjs versions before and including 0.6.11 are vulnerable to Improper Validation of Specified Quantity in Input. Double spending is possible because there is no validation that the publicSignals length is less than the field modulus.
Fix: There are no safe versions of this library available for upgrade. Library included at developer-portal/web/pnpm-lock.yaml:5729.
Reference(s): GHSA-xp5g-jhg3-3rg2, CVE-2023-33252~~
✨ Fixed in commit cc8b939 ✨
decentralgabe
temporarily deployed
to
development
GitHub Actions
Inactive
decentralgabe
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Checklist