Check if relayer funds are enough to process submitted transaction (estimates). #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piohei
force-pushed
the
piohei/check_funds
branch
4 times, most recently
from
67e35d5 to
2588866
Compare
piohei
commented
Sep 2, 2024
| .await?; | ||
|
|
||
| let block_fees = app.db.get_latest_block_fees_by_chain_id(relayer.chain_id).await?; | ||
| if let Some(block_fees) = block_fees { |
There was a problem hiding this comment.
I decided to check funds only if estimates are available. Other option is to return error here if we think it is crucial for us.
piohei
force-pushed
the
piohei/check_funds
branch
from
2588866 to
6879b43
Compare
piohei
force-pushed
the
piohei/check_funds
branch
from
6879b43 to
575d7cb
Compare
Dzejkop
reviewed
Sep 3, 2024
src/service.rs
Outdated
| @@ -82,6 +82,18 @@ impl Service { | |||
|
|
|||
| Ok(()) | |||
| } | |||
|
|
|||
| pub async fn is_estimates_ready_for_chain(&self, chain_id: u64) -> bool { | |||
There was a problem hiding this comment.
Suggested change
| pub async fn is_estimates_ready_for_chain(&self, chain_id: u64) -> bool { | |
| pub async fn are_estimates_ready_for_chain(&self, chain_id: u64) -> bool { |
?
Dzejkop
reviewed
Sep 3, 2024
tests/common/service_builder.rs
Outdated
| @@ -94,6 +94,22 @@ impl ServiceBuilder { | |||
| let client = | |||
| TxSitterClient::new(format!("http://{}", service.local_addr())); | |||
|
|
|||
| // Awaits for estimates to be ready | |||
| let mut is_estimates_ready = false; | |||
There was a problem hiding this comment.
Suggested change
| let mut is_estimates_ready = false; | |
| let mut are_estimates_ready = false; |
Dzejkop
reviewed
Sep 3, 2024
src/service.rs
Outdated
|
|
||
| pub async fn is_estimates_ready_for_chain(&self, chain_id: u64) -> bool { | ||
| let res = self | ||
| ._app |
There was a problem hiding this comment.
Please change struct field to app
Dzejkop
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction cost is estimated based on gas limit and current gas cost estimates based on chain.