Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: optimized get token balances #104

Merged
merged 11 commits into from
Oct 18, 2023
Merged

add: optimized get token balances #104

merged 11 commits into from
Oct 18, 2023

Conversation

anondev2323
Copy link
Contributor

Right now it just checks for native addresses. The follow up for this would be to create an getWrappedAssets method, so you could call it for wrapped assets as well as native: getBalances(getWrappedAssets(...))

barnjamin
barnjamin reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@barnjamin barnjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! looks great, just a few nits

@barnjamin barnjamin merged commit 73c5a5e into develop Oct 18, 2023
1 check passed
@barnjamin barnjamin deleted the get-token-balances branch October 18, 2023 15:51
barnjamin pushed a commit that referenced this pull request Oct 23, 2023
@anondev2323 @barnjamin
add: optimized get token balances (#104)
5b6e573
barnjamin pushed a commit that referenced this pull request Nov 25, 2023
@anondev2323 @barnjamin
add: optimized get token balances (#104)
0ee1959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnjamin barnjamin barnjamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anondev2323 @barnjamin