Node/EVM: Verify EVM chain ID #4116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
node_evm_verify_evm_chain_id
branch
4 times, most recently
from
dc63747 to
b86e837
Compare
bruce-riley
force-pushed
the
node_evm_verify_evm_chain_id
branch
4 times, most recently
from
099b719 to
5e0d29a
Compare
bruce-riley
force-pushed
the
node_evm_verify_evm_chain_id
branch
from
5e0d29a to
b1af0f0
Compare
panoel
reviewed
Feb 20, 2025
panoel
reviewed
Feb 20, 2025
panoel
reviewed
Feb 20, 2025
panoel
reviewed
Feb 20, 2025
panoel
reviewed
Feb 20, 2025
panoel
previously approved these changes
Feb 20, 2025
johnsaigle
previously approved these changes
Feb 20, 2025
johnsaigle
approved these changes
Feb 20, 2025
bruce-riley
force-pushed
the
node_evm_verify_evm_chain_id
branch
from
cab82a1 to
c28fd39
Compare
johnsaigle
approved these changes
Feb 24, 2025
panoel
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check on start up of the EVM watcher to verify that the EVM chain ID of the RPC endpoint matches what is expected for the configured chain. This is to protect against a guardian connecting to the wrong chain by mistake.
Additionally, the reobservation with custom endpoint feature (#4260) will be updated to perform this check so that a reobservation is not attempted on the wrong chain.
This PR implements two static configuration maps that define information about each EVM watcher (one for mainnet and one for testnet) and adds a utility to verify that the EVM chain IDs specified in the config match what is reported for a well-known public RPC for that chain.
This PR centralizes much of the data associated with an EVM chain, which will simplify the addition of new chains.