feat: mainnet validator hot swaps #4203
Merged
+376
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelsmith-2019
requested review from
nik-suri,
johnsaigle,
mdulin2 and
evan-gray
as code owners
nik-suri
reviewed
Dec 19, 2024
mdulin2
reviewed
Jan 13, 2025
|
Is this truly affecting only mainnet. Please, be reminded that in testnet the guardian set size is one (1) and we should keep the ability to rotate the key. cc @andreclaro |
|
This is expanding the ability to rotate keys. Right now, there is a restriction that the hot swap is only allowed when there is a single Guardian (aka testnet). This allows for all Guardians to do the hot swap at any point. |
mdulin2
reviewed
Jan 15, 2025
mdulin2
previously approved these changes
Jan 15, 2025
nik-suri
previously approved these changes
Jan 27, 2025
nik-suri
approved these changes
Jan 28, 2025
mdulin2
approved these changes
Jan 29, 2025
evan-gray
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows mainnet validator hot swapping. Previously, only single validator clusters allowed hot swapping for testnet purposes. This PR removes that check and introduces an integration test which validates the process of swapping an existing guardian's validator to a new validator and then back again.