ci: Fix docker-related errors in Algorand job #4374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
force-pushed
the
ci-algorand-docker
branch
from
7a49da9 to
ba010b4
Compare
johnsaigle
force-pushed
the
ci-algorand-docker
branch
2 times, most recently
from
3e87de2 to
2488e3e
Compare
This is an attempt to fix errors related to 'docker compose' not being installed. The version of the sandbox we use has a bug with its `docker compose` check. This commit includes a workaround to get CI to work.
johnsaigle
force-pushed
the
ci-algorand-docker
branch
from
2488e3e to
a5dcd9c
Compare
evan-gray
approved these changes
May 13, 2025
djb15
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes errors related to 'docker compose' not being installed. This should unblock CI.
The version of the sandbox we use has a bug with its
docker composecheck. This commit includes a workaround to get CI to work.
I tried upgrading to the latest
sandboxversion but it caused other errors. Rather than attempt a full upgrade, this commit does a cheeky rewrite of the upstreamsandboxscript to fix how it detects docker.Compare with:
https://github.com/algorand/sandbox/blob/59803a56a2d254bc49df36e964dc4e4f94435446/sandbox#L45-L55
Upstream bug fix PR:
algorand/sandbox#206