Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(texture): add TextureManager #9

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

fallenoak
Copy link
Member

This PR introduces the TextureManager, an in-memory cache for THREE.Textures used to render model formats.

@codecov-commenter
Copy link

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (4d672be) 29.47% compared to head (c516a48) 27.45%.

Files Patch % Lines
src/lib/TextureManager.ts 0.00% 44 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   29.47%   27.45%   -2.03%     
==========================================
  Files           8        9       +1     
  Lines         665      714      +49     
  Branches      164      176      +12     
==========================================
  Hits          196      196              
- Misses        390      434      +44     
- Partials       79       84       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fallenoak fallenoak merged commit 6970417 into main Dec 28, 2023
2 checks passed
@fallenoak fallenoak deleted the feat-texture-add-texture-manager branch December 28, 2023 05:05
@github-actions github-actions bot mentioned this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants