Implement mastery fire mage build#1292
Merged
1337LutZ merged 2 commits intowowsims:masterfrom Jan 14, 2026
Merged
Conversation
…stion - Add GCD: 0 to Combustion spell to make it off-GCD - Add mastery fire preset build with gear, APL, talents, EP weights - Add MasteryFireOptions (Mage Armor) and MasteryFireConsumables (no prepot) - Add settings to P2/P3 presets for Molten Armor and prepot - Register mastery preset in sim.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new "Mastery" preset for Fire Mage, including gear, talents, consumables, rotation, and stat weights, and integrates it into the UI for easy selection. Additionally, it improves the simulation logic by ensuring the mage reacts to aura events, and refines spell configuration for Combustion. These changes make it easier to simulate and optimize a mastery-focused Fire Mage build.
Mastery Preset Integration
mastery_fire.gear.jsonand imported it into the presets (ui/mage/fire/presets.ts). [1] [2]mastery_fire.apl.json) and incorporated it into the preset rotations (ui/mage/fire/presets.ts). [1] [2]ui/mage/fire/presets.ts,ui/mage/fire/sim.tsx). [1] [2] [3] [4] [5]Simulation Logic Improvements
ReactToEventin key aura handlers (alter_time.go,heating_up.go,talents.go). [1] [2] [3]combustion.go).