Skip to content

[Item] Disable legendary item procs in CMs #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hillerstorm merged 1 commit into from
Jan 20, 2026
Merged

[Item] Disable legendary item procs in CMs #1300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sim/common/mop/cloaks_phase_4_54.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ func init() {
character := agent.GetCharacter()
label := "Xing-Ho, Breath of Yu'lon"

if character.Back().ChallengeMode {
return
}

parentAura := core.MakePermanent(character.RegisterAura(core.Aura{
Label: "Essence of Yu'lon - Dummy Aura",
Duration: core.NeverExpires,
Expand Down Expand Up @@ -85,6 +89,10 @@ func init() {
core.NewItemEffect(itemID, func(agent core.Agent, state proto.ItemLevelState) {
character := agent.GetCharacter()

if character.Back().ChallengeMode {
return
}

flurrySpell := character.RegisterSpell(core.SpellConfig{
ActionID: core.ActionID{SpellID: 147891},
SpellSchool: core.SpellSchoolPhysical,
Expand Down Expand Up @@ -180,6 +188,10 @@ func init() {
core.NewItemEffect(itemID, func(agent core.Agent, state proto.ItemLevelState) {
character := agent.GetCharacter()

if character.Back().ChallengeMode {
return
}

dummyAura := core.MakePermanent(character.RegisterAura(core.Aura{
Label: label,
Duration: core.NeverExpires,
Expand Down
14 changes: 14 additions & 0 deletions sim/common/mop/metagems.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ func init() {
// (Approximately [19.27 + Haste] procs per minute)
core.NewItemEffect(95346, func(agent core.Agent, _ proto.ItemLevelState) {
character := agent.GetCharacter()

if character.Head().ChallengeMode {
return
}

var target *core.Unit

isHunter := character.Class == proto.Class_ClassHunter
Expand Down Expand Up @@ -116,6 +121,11 @@ func init() {
// (Approximately 1.35 procs per minute)
core.NewItemEffect(95347, func(agent core.Agent, _ proto.ItemLevelState) {
character := agent.GetCharacter()

if character.Head().ChallengeMode {
return
}

hasteMulti := 1.3

aura := character.GetOrRegisterAura(core.Aura{
Expand Down Expand Up @@ -160,6 +170,10 @@ func init() {
core.NewItemEffect(95344, func(agent core.Agent, _ proto.ItemLevelState) {
character := agent.GetCharacter()

if character.Head().ChallengeMode {
return
}

aura := character.GetOrRegisterAura(core.Aura{
Label: "Fortitude",
ActionID: core.ActionID{SpellID: 137593},
Expand Down
5 changes: 3 additions & 2 deletions sim/hunter/item_sets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,9 @@ var SaurokStalker = core.NewItemSet(core.ItemSet{
})

var BattlegearOfTheUnblinkingVigil = core.NewItemSet(core.ItemSet{
ID: 1195,
Name: "Battlegear of the Unblinking Vigil",
ID: 1195,
Name: "Battlegear of the Unblinking Vigil",
DisabledInChallengeMode: true,
Bonuses: map[int32]core.ApplySetBonus{
2: func(agent core.Agent, setBonusAura *core.Aura) {
// Aimed Shot, Arcane Shot and Multi-shot reduce the cooldown of Rapid Fire by [Bestial Wrath: 4] [Aimed Shot: 4 / 8] seconds per cast.
Expand Down