Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Warlock Draconic tank tier 2 / Wicked #1114

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

OmegaHelix
Copy link

item_sets_pve:

  1. Add Warlock Tank Tier 2 2/4/6p set bonuses

Base spell changes:
Death Coil / Drain Life:

  1. Use CalcAndDealHealing to trigger OnHealDealt callback

Lifetap:

  1. Expose Ranks / Damage values for tier 2p to hit target
  2. Add SpellFlagBinary to avoid partial resists
  3. Change to OutcomeAlwaysHit so it no longer crits / misses

2/3 lowers dps's dps tests by ~1, expected

action_id:

  1. Add (Heal) for clarity, case needed to avoid (??) with death coil / drain life heals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants