Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.19 - Preconnect to external domains - Beacon insertion part #7246

Open
piotrbak opened this issue Jan 26, 2025 · 1 comment · May be fixed by #7301
Open

3.19 - Preconnect to external domains - Beacon insertion part #7246

piotrbak opened this issue Jan 26, 2025 · 1 comment · May be fixed by #7301
Assignees
Labels
effort: [S] 1-2 days of estimated development time
Milestone

Comments

@piotrbak
Copy link
Contributor

User Story
As a user, I’d like beacon to collect data when there’s no entry in the db

Acceptance Criteria

  • When visiting the uncached page while no data in DB, the same beacon script is added to process the preload fonts (no regression for beacon script injection)
@piotrbak piotrbak added this to the 3.19-prealpha milestone Jan 26, 2025
@jeawhanlee
Copy link
Contributor

Most of the part that handles this have already been introduced in 3.16 . We can find that module here We just need to declare the factory to be loaded there.

Scope a solution ✅

  • Create a Factory for PreconnectExternalDomains like the way we do here for ATF if not created
  • Create the queries method (product) required for this task if not created and make sure it extends WP_Rocket\Engine\Common\PerformanceHints\Database\Queries\AbstractQueries and implements ``WP_Rocket\Engine\Common\PerformanceHints\Database\Queries\QueriesInterface
  • Update service providers if not already having the factory

Estimate the effort ✅

[S]

@piotrbak piotrbak added the effort: [S] 1-2 days of estimated development time label Feb 6, 2025
@Khadreal Khadreal self-assigned this Feb 11, 2025
Khadreal added a commit that referenced this issue Feb 13, 2025
@Khadreal Khadreal linked a pull request Feb 13, 2025 that will close this issue
8 tasks
@Miraeld Miraeld removed a link to a pull request Feb 14, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [S] 1-2 days of estimated development time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants