Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7246 3.19 - Preconnect to external domains - Beacon insertion part #7301

Open
wants to merge 4 commits into
base: feature/preload-fonts
Choose a base branch
from

Conversation

Khadreal
Copy link
Contributor

Description

Fixes #7246

Type of change

  • New feature (non-breaking change which adds functionality).

Detailed scenario

N/A

Technical description

Documentation

Add factory class for Preload fonts to service provider

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Khadreal Khadreal self-assigned this Feb 11, 2025
@Khadreal Khadreal marked this pull request as ready for review February 12, 2025 12:46
@Khadreal Khadreal force-pushed the feature/7246-beacon-insertion-part branch from 653c3c4 to 74a587c Compare February 13, 2025 11:13
@Khadreal Khadreal requested a review from a team February 13, 2025 13:12
@Khadreal
Copy link
Contributor Author

Test is failing which would be resolve when this issue is completed.

@Miraeld Miraeld linked an issue Feb 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.19 - Preconnect to external domains - Beacon insertion part
1 participant