Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Regex validation for field #1118

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Conversation

dipuchaudhary
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Previously, We don't have the option to add custom regular expression validation for the field to validate it. Currently, this option is available for email, first name, last name, input field, number field and website field. The PR will introduce this feature.

How to test the changes in this Pull Request:

  1. Go to form builder then advanced settings of field options.
  2. enable regex validation and select a predefined regular expression or input a custom regular expression.
  3. update the form and verify whether it is working fine or not.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Feature - Regex validation for field.

Copy link
Member

@deepench deepench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@MILAN88888 MILAN88888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deepench deepench merged commit 680ac86 into develop Jul 17, 2023
1 check passed
@deepench deepench deleted the EVF-627-regex-validation branch July 17, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants