-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVF-580 Feature - Custom CSS and JS for form #1123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for barging in, but this PR could use more streamlining: kindly use a package manager with a bundler to keep track of JS dependencies, especially something as big as ace. Since evf already uses npm with either webpack or grunt(afaik), bundling should be a breeze.
Has the EVF team worked over how they'll tackle how large the plugin payload will be post-deployment? This one is a bit concerning : It's not like the feature is unwelcome, but looking to use a CDN, perhaps a common repository that are already available could be a better approach as opposed to self-hosting(although some would definitely prefer that).
Again, fascinating approach WPEverest is taking with this feature, I'm still trying to wrap my head around why the team thinks this feature will be a good idea, and not a potential security risk - letting the frontend run code essentially arbritarily is a big no-no. It could end up encouraging common attack patterns such as XSS/ACE. This feature makes sense in a dev-oriented package, not something that'll be accessed by the average barely tech-saavy WordPress users. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
All Submissions:
Changes proposed in this Pull Request:
This PR introduces a feature to add custom styles( CSS ) and scripts( JS ) to the frontend page where the form is loaded.
How to test the changes in this Pull Request:
Types of changes:
Other information:
Changelog entry