Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Upgrade to the pro improve for dragging a field #1124

Conversation

MILAN88888
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Previously, If users had an Everest form pro version and he/she activated evf pro by any license plan. Then in the form builder, on the click of the locked field, it showed Upgrade your plan notice, which was incorrect according to the activated license plan. This PR is changing the notice according to the user's license plan. If the locked field is available in the user's license plan then it notifies as an install or activate addon. If not, then upgrade your plan.

How to test the changes in this Pull Request:

  1. First Activate Everest Form Pro -> Activate with any license plan key.
  2. Then Go to form builder -> click on the locked field -> see the notice message
  3. And verify with your plan key, if this field lies under your plan key then it will show an install or activate(if the addon already exists) message. If not, then the upgrade plan notice will come.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Enhancement - Upgrade to the pro improve for dragging a field.

Copy link
Contributor

@dipuchaudhary dipuchaudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@salimshrestha98 salimshrestha98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 👍

@deepench deepench merged commit 655fdcb into develop Jul 17, 2023
@deepench deepench deleted the EVF-590-enhancement/upgrade-to-the-pro-improve-for-dragging-a-field branch July 17, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants