Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Hide empty fields in the email. #1143

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

deepench
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Previously, when the field was empty, it would display in the email. This pull request addresses this issue and resolves it.

How to test the changes in this Pull Request:

  1. Create a form.
  2. Submit the form with an empty field.
  3. Verify if the empty field is shown or not.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Fix - Hide empty fields in the email.

Copy link

@Sanjuacharya Sanjuacharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deepench deepench merged commit 9ae668a into develop Aug 23, 2023
1 check passed
@deepench deepench deleted the EVF-777-hide-empty-fields-in-the-email-entries branch August 23, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants