Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Block design all messed up when viewed in block editor. #1279

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Fix - Block design all messed up when viewed in block editor. #1279

merged 5 commits into from
Jun 28, 2024

Conversation

MILAN88888
Copy link
Contributor

@MILAN88888 MILAN88888 commented Jun 24, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Previously, The design of the form was messed in the block editor when we choose a form. This PR fixes that design issue.
Note :- Please before test run grunt css. No need to build.
image

Please test the zip in the two or more testing site. Zip link:- https://themegrill.atlassian.net/browse/EVF-1026?focusedCommentId=21855

How to test the changes in this Pull Request:

  1. Drag a form selector block and choose block
  2. Verify the design of that form in block editor
    3.Also verify the form's front-end validation

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Fix - Block design all messed up when viewed in block editor.

@MILAN88888 MILAN88888 self-assigned this Jun 24, 2024
@MILAN88888 MILAN88888 requested a review from deepench June 26, 2024 03:54
NirajChaudhary143
NirajChaudhary143 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@NirajChaudhary143 NirajChaudhary143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

riteelama
riteelama approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@riteelama riteelama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

joshianup1
joshianup1 approved these changes Jun 28, 2024
View reviewed changes
Copy link

@joshianup1 joshianup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

deepench
deepench approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@deepench deepench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deepench deepench added the bug Something isn't working label Jun 28, 2024
@riteelama riteelama merged commit b971985 into pre-develop Jun 28, 2024
1 check passed
@riteelama riteelama deleted the EVF-1026-fix/everest-forms-block-design-all-messed-up-when-viewed-in-block-editor branch June 28, 2024 10:39
deepench added a commit that referenced this pull request Jul 3, 2024
@deepench @MILAN88888
@ayushstha1443 @riteelama @NirajChaudhary143 @Sujit-shrestha
Fix - Post Meta Smart tag not working. (#1286)
a7672c5 
* Version bump 3.0.0.1 for release

* Version bump 3.0.0.1 for release

* Fix - Unwanted file

* Fix - checkbox limit issue

* Fix - missing browser language

* Fix - post meta smart tag issue

* Added - filetr for image generation

* form builder collapse design fix

* Enhancement - Global Setting Premium Sidebar. (#1281)

* Added - Sidebar design

* global settings premium sidebar design fix

* addded toogle for checkbox

* evf global settings premium sidebar toggle option added and design fixed

* addded button

* addded button

* global settings premium sidebar design fix

* global settings pro sidebar transition added

* Added - COntent for promotionla content

* Changelog updated

---------

Co-authored-by: Ayush Shrestha <ayushstha143@gmail.com>

* Fix - Block design all messed up when viewed in block editor. (#1279)

* Fix - Form block design when viewed in editor

* Fix - Style enqueue id

* Fix - Missing file path

* Chnagelog updated

---------

Co-authored-by: riteelama <riteelama@gmail.com>

* Tweak - Test email input and button design (#1280)

* Added - input_test_button field for test email purpose

* enhance - report test email design

* Fix - PHPCS issue

* global settings email template send test mail section design fix

* Fix - Spinner on test email and test email tooltip text

* Tweak - text of report email

* Changelog updated

---------

Co-authored-by: Ayush Shrestha <ayushstha143@gmail.com>
Co-authored-by: Deependra Chaudhary <elendoff11@gmail.com>

* Fix - Wrong instruction on captcha (#1278)

* Fix - wrong instruction on captcha

* Update - Chnagelog

---------

Co-authored-by: riteelama <riteelama@gmail.com>

* Fix - Email template on email clone, save and continue forms (#1275)

* Fix - Email template for clone and svae and continue

* phpcs fixed

* Update - Changelog

---------

Co-authored-by: Deependra Chaudhary <elendoff11@gmail.com>

* Feature - Import entries in our form using csv (#1266)

* Added - Import entries and Mapping Frontend

* Added - Csv data is formated to import in evf-entries

* Added - Imported csv data witout background processing

* Added - Import csv data to entries table using background processing

* Fix - Phpcs

* Fix -PHPCS

* Fix -PHPCS

* Fixed - Undefined index

* Fix - phpcs

* Fix - phpcs

* Fix - Import entries not working when quotes are in heading of csv

* Fix - Error handling

* Fix - Remove lg

* Chnagelog updated

---------

Co-authored-by: MILAN88888 <chaudharymilan996@gmail.com>
Co-authored-by: Deependra Chaudhary <elendoff11@gmail.com>

* Enhance - Dashboard page (#1271)

* Added - Input field to enter the activation license key

* Added - Validation for license field input

* Added - License and plugin version validation

* Added - Loaading on button while retrieving license activation response

* Added - Page reload after the license activation

* Added -Toggle to activate/deactivate the module

* Fix - plugin activation/deactivation toggle and upgrade plan

* Added - Settings URL for global settings

* Fix - Settings URL and button style

* Added - Play button for demo vido on module hover

* Fix - Video URL

* Added - Video Player for modules

* Fix - Video play option while license deactivated

* Fix - Searching module

* Added - copy button to copy shortcode

* Added - Shortcode copied to clipboard

* Tweak - Shortcode copy style

* Fix - Settings icon size, search module and settings link

* Add - open global settings on new tab

* Add - Shortcode copy icon for shortcode example

* Add - video url for ai contact and frontend listing

* Remove - Pop up for plan update in free version

* Fix - Searching of module

* Fix - Video loading and bulk plugin activation or deactivation

* Fix - No item found text

* Fix - Addon activation issues

* Fix - Upgrade plan UTM

* Fix - License Activation

* Add - id to some shortcode

* Fix - Search issue

* Tweak - Width of notice drawer

* Fix - Sorting of modules by descending order

* Fix - Sorting of modules on popular basis

* Update - Changelog

---------

Co-authored-by: Deependra Chaudhary <elendoff11@gmail.com>

* Add - Added function to get next key in array (#1282)

* Add - Added function to get next key in array

* Add - Added function to get next key in array

* Code refactor

* Updated - Chnagelog

---------

Co-authored-by: Sujit Shrestha <sujitshrestha0004@gmal.com>
Co-authored-by: riteelama <riteelama@gmail.com>

* Grunted JS and CSS

* Fix -Page reload after license activation

* Grunted Js

* Fix - URL for email templates, survey polls and quiz and sma notification docs

* Fix - Addon activation processing and toast text consistency

* Grunted JS

* Removed src map file

* Fix - File upload for importing csv

* Fix - dash icons issue

* Fix - Icons not showing issue in submit

* Fix - Wrong instruction of captcha issue

* Tweak - Hide map button

* Added - Hide forms when map csv button is clicked

* Fix  - design issue in global setting

* Grunted files

---------

Co-authored-by: MILAN88888 <chaudharymilan996@gmail.com>
Co-authored-by: Ayush Shrestha <ayushstha143@gmail.com>
Co-authored-by: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com>
Co-authored-by: riteelama <riteelama@gmail.com>
Co-authored-by: Ritee Lama <89212873+riteelama@users.noreply.github.com>
Co-authored-by: Niraj Chaudhary <99162269+NirajChaudhary143@users.noreply.github.com>
Co-authored-by: MrSujiit <63456073+Sujit-shrestha@users.noreply.github.com>
Co-authored-by: Sujit Shrestha <sujitshrestha0004@gmal.com>
Co-authored-by: Niraj Chaudhary <nirajchy2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshianup1 joshianup1 joshianup1 approved these changes

@NirajChaudhary143 NirajChaudhary143 NirajChaudhary143 approved these changes

@riteelama riteelama riteelama approved these changes

@deepench deepench deepench approved these changes

Assignees

@MILAN88888 MILAN88888

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MILAN88888 @deepench @riteelama @NirajChaudhary143 @joshianup1