Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev - GetResponse compatibility #1294

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Dev - GetResponse compatibility #1294

merged 2 commits into from
Jul 31, 2024

Conversation

NirajChaudhary143
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Previously, GetResponse is Addon/. This PR shift it to module.

How to test the changes in this Pull Request:

  1. Goto Everest Forms > Global Settings > Integration > Connect Api.
  2. Goto Everest Forms > Form Settings > Integration > Add Integration .

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Dev - GetResponse compatibility

@NirajChaudhary143 NirajChaudhary143 self-assigned this Jul 15, 2024
@deepench deepench requested a review from joshianup1 July 18, 2024 05:05
deepench
deepench approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@deepench deepench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sanjuacharya
Sanjuacharya approved these changes Jul 18, 2024
View reviewed changes
Copy link

@Sanjuacharya Sanjuacharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

MILAN88888
MILAN88888 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@MILAN88888 MILAN88888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

riteelama
riteelama approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@riteelama riteelama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

joshianup1
joshianup1 approved these changes Jul 26, 2024
View reviewed changes
Copy link

@joshianup1 joshianup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NirajChaudhary143 NirajChaudhary143 merged commit 08d4667 into pre-develop Jul 31, 2024
1 check passed
@NirajChaudhary143 NirajChaudhary143 deleted the EVF-1074-dev/get-response-addon-into-module branch July 31, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepench deepench deepench approved these changes

@Sanjuacharya Sanjuacharya Sanjuacharya approved these changes

@riteelama riteelama riteelama approved these changes

@joshianup1 joshianup1 joshianup1 approved these changes

@MILAN88888 MILAN88888 MILAN88888 approved these changes

Assignees

@NirajChaudhary143 NirajChaudhary143

Labels
Enhancement New feature or request [Status] Needs Changelog [Status] Needs Docs [Status] Needs Review [Status] Needs Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NirajChaudhary143 @deepench @Sanjuacharya @riteelama @joshianup1 @MILAN88888