Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Custom file name settings #1307

Conversation

NirajChaudhary143
Copy link
Contributor

@NirajChaudhary143 NirajChaudhary143 commented Jul 31, 2024

All Submissions:

Changes proposed in this Pull Request:

Previously, file name are generated randomly. This PR gives user to add custom file name.

How to test the changes in this Pull Request:

  1. Creare new form and drag file upload.
  2. Go to File upload >> Field Options >> Custom File name
  3. Insert custom name.
  4. Preview form and and upload file.
  5. Check entries whether custom file name is set or not.

Dependency PR

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Enhancement - Custom file name settings

Copy link
Contributor

@riteelama riteelama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NirajChaudhary143 NirajChaudhary143 merged commit d722733 into pre-develop Aug 1, 2024
1 check failed
@NirajChaudhary143 NirajChaudhary143 deleted the EVF-1088-PDF-file-name-customization-in-PDF-submission-addon branch August 1, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants