Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak - Catch mail send error #1316

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Conversation

deepench
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Previously when our Everest Forms Plugin's mail was not being sent or received by end-users, there was no way to know what was actually the issue. This PR introduces a notice displayed to the admin when 5 consecutive email send is failed with a detailed error message or report which will be displayed in our Everest Forms -> Tools -> Logs under evf_mail_errors Log.

How to test the changes in this Pull Request:

  1. It is hard to replicate such issues as email will be sent in our local environment.
  2. To test this, install any smtp plugin and enable a mailer and configure it to fail. For example, Install WP MAIL SMTP plugin, setup google as mailer and do not configure it fully. A user authentication related error occur while sending a mail from the system.
  3. Click on Send Test Email, a detailed error message should be displayed and log should have been added to Everest Forms -> Tools -> Logs section. Verify it.
  4. Now try to submit the form, if the mail send failed threshold crosses 5, then a notice will be displayed to the admin in admin area.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Change log entry

Tweak - Catch mail send error.

Copy link
Contributor

@riteelama riteelama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@NirajChaudhary143 NirajChaudhary143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@joshianup1 joshianup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@MILAN88888 MILAN88888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deepench deepench merged commit 5b33fae into pre-develop Sep 5, 2024
1 check failed
@deepench deepench deleted the EVF-1141-email-log-in-evf branch September 5, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants