Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Send file directly as an attachment. #1326

Conversation

deepench
Copy link
Member

@deepench deepench commented Sep 2, 2024

All Submissions:

Changes proposed in this Pull Request:

Previously When we enable Disable storing entry information. The file upload field is stored in server and link is provided in email.This PR solves this issue.

How to test the changes in this Pull Request:

  1. Create a form with file upload.
  2. Go to > Settings > General > Disable storing entry information.
  3. Submit the form and check the file uploaded will send as attachment.
  4. The uploaded file will no stored in server.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Enhancement - Send file directly as an attachment. .

@deepench deepench changed the base branch from develop to pre-develop September 4, 2024 08:09
Copy link
Contributor

@NirajChaudhary143 NirajChaudhary143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@joshianup1 joshianup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@MILAN88888 MILAN88888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MILAN88888 MILAN88888 merged commit 2b89746 into pre-develop Sep 6, 2024
1 check failed
@MILAN88888 MILAN88888 deleted the EVF-1180-enhancement-send-file-directly-to-email-as-attachment branch September 6, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Enhancement New feature or request Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants