Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Global Setting Premium Sidebar Design Issue. #1328

Merged
merged 7 commits into from
Sep 6, 2024

Conversation

deepench
Copy link
Member

@deepench deepench commented Sep 2, 2024

All Submissions:

Changes proposed in this Pull Request:

This PR fixes:-
Remove the sliding effect in settings sidebar.
Design issue in small screen.

How to test the changes in this Pull Request:

  1. Go to global setting
  2. check the design issue and flickering issue is fixed or not.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Fix - Global Setting Premium Sidebar Design Issue.

Copy link
Contributor

@MILAN88888 MILAN88888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deepench deepench changed the base branch from develop to pre-develop September 5, 2024 06:59
Copy link

@joshianup1 joshianup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@NirajChaudhary143 NirajChaudhary143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deepench deepench merged commit 400ea0f into pre-develop Sep 6, 2024
1 check failed
@deepench deepench deleted the evf-816-global-settings-design-fix branch September 6, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved bug Something isn't working Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants