Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak - Moved Campaign Monitor to module #1336

Conversation

NirajChaudhary143
Copy link
Contributor

@NirajChaudhary143 NirajChaudhary143 commented Sep 19, 2024

All Submissions:

Changes proposed in this Pull Request:

Previously, Campaign monitor is addon, This PR move it to module system.

How to test the changes in this Pull Request:

  1. Read documentation Docs

Dependency PR Pro PR

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Tweak - Moved Campaign Monitor to module

Copy link
Contributor

@riteelama riteelama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NirajChaudhary143 NirajChaudhary143 removed the request for review from MILAN88888 November 13, 2024 03:43
Copy link

@joshianup1 joshianup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@deepench deepench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NirajChaudhary143 NirajChaudhary143 merged commit ce64b83 into pre-develop Nov 14, 2024
1 check passed
@NirajChaudhary143 NirajChaudhary143 deleted the EVF-1197-enhancement/campaign-monitor-into-module branch November 14, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants