Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev - User Registration Social Login #1363

Merged
merged 6 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions assets/extensions-json/sections/all_extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -135,23 +135,6 @@
"demo_video_url": "pcwPjCt7N2I",
"popular_rank": 8
},
{
"title": "User Registration",
"slug": "everest-forms-user-registration",
"name": "Everest Forms User Registration",
"image": "extensions-json/sections/images/user-registration.png",
"excerpt": "Allows you to create a custom WordPress user registration form instantly in few simple steps. You can add or remove input fields as per the style of your registration using this feature.",
"link": "https://docs.everestforms.net/docs/user-registration/?utm_source=dashboard-all-feature&utm_medium=card-documentation-link",
"released_date": "16/07/2019",
"plan": [
"personal",
"agency",
"themegrill agency"
],
"setting_url": "",
"demo_video_url": "MEyuznG2Tok",
"popular_rank": 12
},
{
"title": "Google Sheets",
"slug": "everest-forms-google-sheets",
Expand Down Expand Up @@ -966,6 +949,23 @@
"setting_url": "admin.php?page=evf-settings&tab=integration&section=getgist",
"demo_video_url": "d2Ujl82OJuA",
"popular_rank": "xx"
},
{
"title": "User Registration",
"slug": "everest-forms-user-registration",
"name": "Everest Forms User Registration",
"image": "extensions-json/sections/images/user-registration.png",
"excerpt": "Allows you to create a custom WordPress user registration form instantly in few simple steps. You can add or remove input fields as per the style of your registration using this feature.",
"link": "https://docs.everestforms.net/docs/user-registration/?utm_source=dashboard-all-feature&utm_medium=card-documentation-link",
"released_date": "16/07/2019",
"plan": [
"personal",
"agency",
"themegrill agency"
],
"setting_url": "admin.php?page=evf-settings&tab=user_registration",
"demo_video_url": "MEyuznG2Tok",
"popular_rank": 12
}
]
}
5 changes: 5 additions & 0 deletions assets/images/settings-icons/user_registration.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* Fix - Background color for PDF submission.
* Dev - Get gist integration.
* Dev - Slack Integration Module.
* Dev - User Registration Social Login.


= 3.0.4.2 - 03-11-2024
Expand Down
22 changes: 19 additions & 3 deletions includes/admin/class-evf-admin-settings.php
Original file line number Diff line number Diff line change
Expand Up @@ -258,11 +258,27 @@
$tabs_array[ $current_tab ] = isset( $tabs_array[ $current_tab ] ) ? $tabs_array[ $current_tab ] : array();
}

echo '<div class="everest-forms-options-header">
$class_for_title = isset( $value['id'] ) && ! empty( $value['id'] ) ? 'everest-forms-settings-title_' . $value['id'] : '';

echo '<div class="everest-forms-options-header ' . $class_for_title . '">

Check failure on line 263 in includes/admin/class-evf-admin-settings.php

View workflow job for this annotation

GitHub Actions / Code sniff (PHP 7.4 , WP Latest)

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$class_for_title'.
<div class="everest-forms-options-header--top">';
foreach ( $tabs_array as $icon_key => $icon_value ) {
echo '<span class="evf-forms-options-header-header--top-icon">' . evf_file_get_contents( '/assets/images/settings-icons/' . $icon_key . '.svg' ) . '</span>'; //phpcs:ignore

// For now icon is ignored.
if( isset( $value['image_name'] ) && ! empty( $value['image_name'] ) ) {

Check failure on line 267 in includes/admin/class-evf-admin-settings.php

View workflow job for this annotation

GitHub Actions / Code sniff (PHP 7.4 , WP Latest)

Space after opening control structure is required

Check failure on line 267 in includes/admin/class-evf-admin-settings.php

View workflow job for this annotation

GitHub Actions / Code sniff (PHP 7.4 , WP Latest)

No space before opening parenthesis is prohibited

Check failure on line 267 in includes/admin/class-evf-admin-settings.php

View workflow job for this annotation

GitHub Actions / Code sniff (PHP 7.4 , WP Latest)

Expected 1 space after IF keyword; 0 found

Check failure on line 267 in includes/admin/class-evf-admin-settings.php

View workflow job for this annotation

GitHub Actions / Code sniff (PHP 7.4 , WP Latest)

Empty IF statement detected

/**
* Icon for Settings tab with different icon.
*
* @since 1.7.9
*/

// echo '<span class="evf-forms-options-header-header--top-icon">' . evf_file_get_contents( '/assets/images/settings-icons/' . $value['image_name'] . '.svg' ) . '</span>';

Check failure on line 275 in includes/admin/class-evf-admin-settings.php

View workflow job for this annotation

GitHub Actions / Code sniff (PHP 7.4 , WP Latest)

Inline comments must end in full-stops, exclamation marks, or question marks
}else{

Check failure on line 276 in includes/admin/class-evf-admin-settings.php

View workflow job for this annotation

GitHub Actions / Code sniff (PHP 7.4 , WP Latest)

Expected 1 space after closing brace; 0 found

Check failure on line 276 in includes/admin/class-evf-admin-settings.php

View workflow job for this annotation

GitHub Actions / Code sniff (PHP 7.4 , WP Latest)

Space after opening control structure is required

Check failure on line 276 in includes/admin/class-evf-admin-settings.php

View workflow job for this annotation

GitHub Actions / Code sniff (PHP 7.4 , WP Latest)

No space before opening parenthesis is prohibited

Check failure on line 276 in includes/admin/class-evf-admin-settings.php

View workflow job for this annotation

GitHub Actions / Code sniff (PHP 7.4 , WP Latest)

Expected 1 space after ELSE keyword; 0 found
foreach ( $tabs_array as $icon_key => $icon_value ) {
echo '<span class="evf-forms-options-header-header--top-icon">' . evf_file_get_contents( '/assets/images/settings-icons/' . $icon_key . '.svg' ) . '</span>'; //phpcs:ignore
}
}

echo '<h3>' . esc_html( $value['title'] ) . '</h3>
</div>
</div>';
Expand Down
1 change: 1 addition & 0 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@ Yes you can! Join in on our [GitHub repository](https://github.com/wpeverest/eve
* Fix - Tooltips does not work on mobile.
* Fix - Background color for PDF submission.
* Dev - Get gist integration.
* Dev - User Registration Social Login.
* Dev - Slack Integration Module.

= 3.0.4.2 - 03-11-2024
Expand Down
Loading