CMake: Reproducible Output Dir For Generated Field Images Code #7772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilding allwpilib as a subproject
calcmogul
reviewed
Feb 9, 2025
calcmogul
requested changes
Feb 9, 2025
Co-authored-by: Tyler Veness <calcmogul@gmail.com>
calcmogul
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By pre-pending the current build/binary directory to the generated output dir, it ensures the files are still found when allwpilib is used a subproject (cmake or meson). Without doing this, the generated files are not found, do not compile, which ultimately leads to missing symbols when linking libfieldImages.