Skip to content

Commit

Permalink
Changes on PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
alexmigf committed Jul 25, 2023
1 parent b0eed89 commit 99d0dbe
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion assets/js/debug-script.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jQuery( function( $ ) {
} );

let reset = false;
if ( 'reset-settings' == tool ) {
if ( 'reset-settings' === tool ) {
reset = window.confirm( wpo_wcpdf_debug.confirm_reset );
} else {
reset = true;
Expand Down
8 changes: 4 additions & 4 deletions includes/class-wcpdf-settings-debug.php
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public function debug_tools( $tab, $section ) {
<?php
foreach ( $this->get_setting_types() as $type => $name ) {
?>
<option value="<?= $type; ?>"><?= $name; ?></option>
<option value="<?php echo $type; ?>"><?php echo $name; ?></option>
<?php
}
?>
Expand Down Expand Up @@ -201,7 +201,7 @@ public function debug_tools( $tab, $section ) {
<?php
foreach ( $this->get_setting_types() as $type => $name ) {
?>
<option value="<?= $type; ?>"><?= $name; ?></option>
<option value="<?php echo $type; ?>"><?php echo $name; ?></option>
<?php
}
?>
Expand Down Expand Up @@ -418,15 +418,15 @@ public function reset_settings( $data ) {
$message = sprintf(
/* translators: settings type */
__( '%s settings reset successfully!', 'woocommerce-pdf-invoices-packing-slips' ),
$setting_types[$type]
$type
);
wcpdf_log_error( $message, 'info' );
wp_send_json_success( compact( 'type', 'message' ) );
} else {
$message = sprintf(
/* translators: settings type */
__( 'An error occurred when trying to reset the %s settings.', 'woocommerce-pdf-invoices-packing-slips' ),
$setting_types[$type]
$type
);
wcpdf_log_error( $message );
wp_send_json_error( compact( 'message' ) );
Expand Down

0 comments on commit 99d0dbe

Please sign in to comment.