-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display and updated in process documents in PDF document data metabox #782
Open
MohamadNateqi
wants to merge
24
commits into
main
Choose a base branch
from
756-pdf-document-data-in-process
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # assets/js/order-script.js # includes/class-wcpdf-admin.php
@MohamadNateqi can you fix the conflicts? |
# Conflicts: # includes/wcpdf-functions.php
@alexmigf Done. |
alexmigf
requested changes
Jul 9, 2024
alexmigf
requested changes
Jul 10, 2024
alexmigf
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# Conflicts: # includes/class-wcpdf-admin.php # includes/wcpdf-functions.php
@MohamadNateqi can you fix the conflicts please? |
# Conflicts: # views/document-data-metabox.php
alexmigf
requested changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #756
This PR improves the way document data are displayed in the metabox. It includes a check for pending jobs and displays a message if the document is still in the queue. It also adds an AJAX request that refreshes document data, eliminating the need to refresh the page.
Note: For the Pro extension compatibility, this branch should be used: https://github.com/wpovernight/woocommerce-pdf-ips-pro/pull/407
For test purposes, the below snippet can be used to stop the queue from running jobs:
Then, the job can be manually run to test the AJAX update.