Fix preview issue #833
Open
Fix preview issue #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix updating number and date on preview
alexmigf
requested changes
Aug 13, 2024
alexmigf
requested changes
Aug 13, 2024
|
@MohamadNateqi can you fix the conflicts here? |
# Conflicts: # includes/documents/abstract-wcpdf-order-document.php
|
@alexmigf Done. |
|
@MohamadNateqi can you fix the conflicts again please? |
|
@alexmigf Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #829
This PR aims to fix three issues on preview:
null, which is fixed, and now number formats are applied.display_datesetting, which is fixed by introducing a newinitiate_dateand calling it during the preview process.display_numbersetting, which is fixed by introducing a newgenerate_document_numberand calling it during the preview process.