-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: implements PSR-4 Autoloading Standard for Improved Code Structure and Maintainability #840
Conversation
This reverts commit 35def36.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal functions seem to work fine 👍 . I tested:
- All document generation
- Document uploads
- Auto and manual creation
- Document attachments
Didn't notice any slow downs, nor any errors in the logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, I cannot find any errors 🚀
I've been using this since Monday I believe. Havent had any issues with the normal functions of plugin nor with the compatibility of the PT or Pro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The code looks OK.
I have tested various different IPS functionalities without any issues. I will keep my free plugin branch on this one for some time just to test this while working on another tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing this PR since last Wednesday, after the weekly meeting, and haven't gotten any issues so far. I have tested this with Professional, Premium Templates and, mPDF, and everything seems to be working correctly.
Within the testing, I took advantage to check a reported conflict with dompdf caused by “TI WooCommerce Wishlist Premium” (see the issue reports here), and I can confirm that this is solved in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Well done.
|
@szepeviktor we are running Strauss; Composer is handled by it. |
closes #563
Note:
Strauss doesn't correctly apply the new namespace to the
FontLib
class variables, so a manual fix is needed to ensure proper font subsetting functionality. Fix applied here: 4643b01