Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: adds missing deprecated filters to document title methods #880

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Fix: adds missing deprecated filters to document title methods #880

merged 5 commits into from
Oct 8, 2024

Conversation

alexmigf
Copy link
Member

@alexmigf alexmigf commented Oct 8, 2024

closes #879

MohamadNateqi
MohamadNateqi approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@MohamadNateqi MohamadNateqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

includes/documents/class-wcpdf-invoice.php Outdated Show resolved Hide resolved
MohamadNateqi
MohamadNateqi approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@MohamadNateqi MohamadNateqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@alexmigf alexmigf merged commit 23baf95 into main Oct 8, 2024
5 checks passed
@alexmigf alexmigf deleted the 879-fix-missing-deprecated-filters branch October 8, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadNateqi MohamadNateqi MohamadNateqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Legacy filter is not applying on template titles methods
2 participants
@alexmigf @MohamadNateqi