Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: style issue on WC item meta when using dd #29

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

alexmigf
Copy link
Member

No description provided.

wcpdf-mpdf.php Outdated Show resolved Hide resolved
wcpdf-mpdf.php Outdated Show resolved Hide resolved
Copy link
Contributor

@MohamadNateqi MohamadNateqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@MohamadNateqi MohamadNateqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

@YordanSoares YordanSoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexmigf the item's meta values are being hidden in the variations:

mpdf-2 5 3-pr29

FYI, while testing wpovernight/woocommerce-pdf-invoices-packing-slips#892 and this PR, I have forced the replacement of the <p> tags with <dd> in the item meta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants