fix: Handle all exceptions in OembedService to prevent edge case errors.

wrav · Dec 6, 2023 · 6ed493d · 6ed493d
1 parent fc8957e
commit 6ed493d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # oEmbed Changelog
 
+## 2.3.2 - 2023-12-07
+
+### Update
+- Handle all exceptions in OembedService to prevent edge case errors. Reported by @holiday-jan in issue #141. Thanks @holiday-jan
+
 ## 2.3.1 - 2023-10-11
 
 ### Update

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "wrav/oembed",
     "description": "A simple plugin to extract media information from websites, like youtube videos, twitter statuses or blog articles.",
     "type": "craft-plugin",
-    "version": "2.3.0",
+    "version": "2.3.2",
     "keywords": [
         "craft",
         "cms",

diff --git a/src/services/OembedService.php b/src/services/OembedService.php
@@ -82,14 +82,17 @@ public function embed($url, array $options = [], array $cacheProps = [])
 
             /** @var Adapter $media */
             $media = Embed::create($url, $options, $dispatcher);
-        } catch (InvalidUrlException $e) {
+        } catch (\Exception $e) {
             // Trigger notification
             if (Oembed::getInstance()->getSettings()->enableNotifications) {
                 Oembed::getInstance()->trigger(Oembed::EVENT_BROKEN_URL_DETECTED, new BrokenUrlEvent([
                     'url' => $url,
                 ]));
             }
 
+            // Log
+            Craft::info($e->getMessage(), 'oembed');
+
             // Create fallback
             $media = new FallbackAdapter(
                 $e->getResponse(),