Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of stability functions for the tke-epsilon-tpe PBL scheme #2120

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

andreazonato
Copy link
Contributor

@andreazonato andreazonato commented Oct 16, 2024

TYPE: bug fix

KEYWORDS: tke-epsilon-tpe, PBL, stability functions

SOURCE: Andrea Zonato, Royal Netherlands Meteorological Institute (KNMI)

DESCRIPTION OF CHANGES:
Problem:
The stability functions at the surface (phim,phieps) for calculating the boundary values of tke and its dissipation rate in the tke-epsilon-tpe PBL scheme Zonato et al., 2022 does not include the correction by z0.

Solution:
Pass the correct stability functions, calculated in module_sf_sfclayrev.F

LIST OF MODIFIED FILES:
phys/module_bl_keps.F
phys/module_pbl_driver.F

TESTS CONDUCTED:
The Jenkins tests are all passing.

RELEASE NOTE:
The similarity stability functions phim and phieps, necessary for calculating the surface values of tke and dissipation rate in the tke-epsilon-tpe PBL scheme Zonato et al., 2022 have been updated considering the correction term accounting for the roughness length z0. No relevant differences are found in temperature, wind speed, and humidity. Regarding turbulence variables, the stable case has just negligible differences, while the unstable case shows higher values of TKE and dissipation rate and lower values of temperature variance.

@andreazonato andreazonato requested a review from a team as a code owner October 16, 2024 11:33
@dudhia
Copy link
Collaborator

dudhia commented Oct 16, 2024

Can you say something about the effect of this change in the release notes?

@andreazonato
Copy link
Contributor Author

Can you say something about the effect of this change in the release notes?

Updated. I have some plots if needed

@weiwangncar weiwangncar changed the base branch from master to develop October 18, 2024 14:43
@dudhia
Copy link
Collaborator

dudhia commented Oct 18, 2024 via email

Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug fix only

@dudhia
Copy link
Collaborator

dudhia commented Jan 16, 2025

need to check if this passed tests

@weiwangncar
Copy link
Collaborator

It did. This is the regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar weiwangncar merged commit 70855a7 into wrf-model:develop Jan 29, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants