Dynamic Lightning (LPI): Registry/driver/lightning updates only #2258

BarryHLynn · 2025-11-02T18:46:20Z

To add the Dynamic Lightning Scheme to the public version of WRF

New Feature

Lightning-Forecast Lightning Dynamic Lightning Scheme Cloud-to-ground-Lightning, Intracloud Lightning. (LPI code also updated to calculate 3d and 2d LPI)

Barry.H.Lynn@gmail.com; Barry.Lynn@Weather-It-Is.com (Weather It Is, LTD and Hebrew University of Jerusalem)

DESCRIPTION OF CHANGES:

Registry/registry.dyn_light

dyn_em/solve_em.F

phys/Makefile

phys/module_calc_lpi_new.F

phys/module_ltng_pe.F

phys/module_ltng_strokes.F

phys/module_microphysics_driver.F

Just added/modified these routines (based on already published work going back to 2010).

ISSUE: For use when this PR closes an issue.
Fixes #123

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate. This is the Dynamic Lightning Scheme based originally on this paper.

Lynn, B. H., 2017: The Usefulness and Economic Value of Total Lightning Forecasts Made with a Dynamic Lightning Scheme Coupled with Lightning Data Assimilation. Wea. Forecasting, 32, 645–663, https://doi.org/10.1175/WAF-D-16-0031.1.

BarryHLynn · 2025-11-02T23:58:52Z

I accidentally uploaded an abbreviated version of registry.sbm_light. I have uploaded the complete file and all should be well.

dudhia · 2025-11-03T16:12:33Z

OK. We had some automatic checks that failed and will let you know what they are later. This could be special compilation options for example.

BarryHLynn · 2025-11-03T16:42:55Z

Hi Jimy: I just compiled the code I sent you on my machine without a problem. There is an extra variable, "l_obs," which I used to assimilate lightning. Rather than remove it, I just left it, since I may want to use it in the future. It's a new option; I didn't put it under the lightning option schemes (I don't remember why I did this but I think it was complicated merging it with the other codes). Barry

…

On Mon, Nov 3, 2025 at 11:12 AM dudhia ***@***.***> wrote: *dudhia* left a comment (wrf-model/WRF#2258) <#2258 (comment)> OK. We had some automatic checks that failed and will let you know what they are later. This could be special compilation options for example. — Reply to this email directly, view it on GitHub <#2258 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKWLWRTJQYQT7ZYJKJTAMK3325WHPAVCNFSM6AAAAACK5MMZMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIOBRGM2DANRRGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Barry H. Lynn, Ph.D Senior Scientist, Lecturer, The Institute of Earth Sciences, The Hebrew University of Jerusalem, Givat Ram, Jerusalem 91904, Israel Tel: 972 547 231 170 Fax: (972)-25662581 Weather It Is, LTD Weather and Climate Focus https://weather-it-is.com <http://weather-it-is.com> Jerusalem, Israel Local: 02 930 9525 Cell: 054 7 231 170 Int-IS: x972 2 930 9525

weiwangncar · 2025-11-20T11:58:40Z

dyn_em/solve_em.F

   LOGICAL :: f_flux  ! flag for computing averaged fluxes in cu_gd
-   REAL    :: curr_secs, curr_secs2, curr_mins2
-   REAL(8) :: curr_secs_r8, curr_secs2_r8
+   REAL    :: curr_secs, curr_secs2


I don't think you should be making this change. The two lines in the code should be retained.

weiwangncar · 2025-11-20T11:59:15Z

dyn_em/solve_em.F


   TYPE(WRFU_TimeInterval)                    :: tmpTimeInterval, tmpTimeInterval2
   REAL                                       :: real_time
-   REAL(8)                                    :: real_time_r8


The same for this line, which should not be removed.

weiwangncar · 2025-11-20T11:59:32Z

dyn_em/solve_em.F

   curr_secs2 = real_time(tmpTimeInterval2)
-   curr_secs_r8  = real_time_r8(tmpTimeInterval)
-   curr_secs2_r8 = real_time_r8(tmpTimeInterval2)
-   curr_mins2 = REAL( curr_secs2_r8 / 60.0d0 )


The same applies here.

weiwangncar · 2025-11-20T11:59:54Z

dyn_em/solve_em.F

                             , config_flags%use_adaptive_time_step &
-                             , curr_secs, curr_mins2            &
+                             , curr_secs                        &
                             , psim , psih , gz1oz0             &


The same applies here.

weiwangncar · 2025-11-20T12:00:04Z

dyn_em/solve_em.F

      &        ,P8W=p8w            ,P=p_phy            ,PI_PHY=pi_phy     &
      &        ,RHO=grid%rho       ,SPEC_ZONE=grid%spec_zone              &
      &        ,SR=grid%sr              ,TH=th_phy                        &
-      &        ,ssat=grid%ssat, ssati=grid%ssati                          &


weiwangncar · 2025-11-20T12:00:22Z

dyn_em/solve_em.F

 !======================
 #endif
-      &        ,XLAND=grid%xland,SNOWH=grid%SNOW,XICE=grid%XICE           &
+      &        ,XLAND=grid%xland,SNOWH=grid%SNOW                           &  !PMA


The same here.

weiwangncar · 2025-11-20T12:00:51Z

phys/Makefile

-        module_bl_mynnedmf_driver.o \
+        module_bl_mynn_common.o \
+        module_bl_mynn.o \
+        module_bl_mynn_wrapper.o \


These should not be changed in your PR.

weiwangncar · 2025-11-20T12:01:07Z

phys/Makefile

 	module_mp_etanew.o \
 	module_mp_fer_hires.o \
 	module_mp_thompson.o \
-	module_mp_rcon.o \


This should not be removed.

weiwangncar · 2025-11-20T12:01:23Z

phys/Makefile

 	module_mp_wdm5.o \
 	module_mp_wdm6.o \
 	module_mp_wdm7.o \
-	module_mp_udm.o \


This one too, should not be removed.

weiwangncar · 2025-11-20T12:01:48Z

phys/Makefile

 TARGETDIR    =  ./

 $(LIBTARGET) :
-	(cd .. && ./tools/manage_externals/checkout_externals --externals ./arch/Externals.cfg)


You definitely should not remove this line.

weiwangncar · 2025-11-20T12:02:12Z

phys/Makefile

-	else \
-		echo No action required for MYNN-EDMF submodule ; \
-	fi
-


You should not remove these lines either.

weiwangncar · 2025-11-20T12:03:02Z

phys/module_microphysics_driver.F

                      ,cldfra, cldfra_old, exch_h, nsource               &
                      ,qlsink, precr, preci, precs, precg                &
-                      ,xland,snowh,xice,itimestep                        &
+                      ,xland,snowh,itimestep                             &


You should not change it here.

weiwangncar · 2025-11-20T12:03:17Z

phys/module_microphysics_driver.F

 #endif
                      ,qnwfa2d, qnifa2d, qnbca2d                         & ! for water/ice-friendly/black carbon aerosols
                      ,qnocbb2d, qnbcbb2d                                & ! for biomass burning aerosols
-                      ,ssat,ssati                                        &


You should not remove this line.

weiwangncar · 2025-11-20T12:04:02Z

phys/module_microphysics_driver.F

   USE module_state_description, ONLY :                                  &
                     KESSLERSCHEME, LINSCHEME, SBU_YLINSCHEME, WSM3SCHEME, WSM5SCHEME    &
-                    ,WSM6SCHEME, ETAMPNEW, FER_MP_HIRES, THOMPSON, THOMPSONAERO, RCON_MP_SCHEME, THOMPSONGH, FAST_KHAIN_LYNN_SHPUND, MORR_TWO_MOMENT     &
+                    ,WSM6SCHEME, ETAMPNEW, FER_MP_HIRES, THOMPSON, THOMPSONAERO, THOMPSONGH, FAST_KHAIN_LYNN_SHPUND, MORR_TWO_MOMENT     &


Should not change this line.

weiwangncar · 2025-11-20T12:04:32Z

phys/module_microphysics_driver.F

                    ,GSFCGCESCHEME, WDM5SCHEME, WDM6SCHEME, NSSL_2MOM, MADWRF_MP  &
                    ,FER_MP_HIRES_ADVECT & 
-                    ,WSM7SCHEME, WDM7SCHEME, UDMSCHEME &
+                    ,WSM7SCHEME, WDM7SCHEME &


Should not change this line.

weiwangncar · 2025-11-20T12:04:50Z

phys/module_microphysics_driver.F

   USE module_mp_wsm7
   USE module_mp_etanew
   USE module_mp_fer_hires
-   USE module_mp_rcon


Should not remove this line.

weiwangncar · 2025-11-20T12:05:07Z

phys/module_microphysics_driver.F

   USE module_mp_wdm5
   USE module_mp_wdm6
   USE module_mp_wdm7
-   USE module_mp_udm


Should not remove this line.

weiwangncar · 2025-11-20T12:05:34Z

phys/module_microphysics_driver.F

 ! Optional
 !
-   REAL, OPTIONAL, DIMENSION( ims:ime , kms:kme, jms:jme ) , INTENT(OUT) :: refl_10cm,ssat,ssati
+   REAL, OPTIONAL, DIMENSION( ims:ime , kms:kme, jms:jme ) , INTENT(OUT) :: refl_10cm


should not change this line.

weiwangncar · 2025-11-20T12:06:10Z

phys/module_microphysics_driver.F

                     dbz      = refl_10cm,               &
-                     ssat3d   = ssat,                    &
-                     ssati    = ssati,                   &
-                     nssl_ssat_output = config_flags%nssl_ssat_output, &


should not remove these lines.

weiwangncar · 2025-11-20T12:06:35Z

phys/module_microphysics_driver.F

-              ENDIF
-             ELSE
-                CALL wrf_error_fatal ( 'arguments not present for calling rcon' )
-             ENDIF


Should not remove these lines.

weiwangncar · 2025-11-20T12:06:57Z

phys/module_microphysics_driver.F

-             ELSE
-               CALL wrf_error_fatal ( 'arguments not present for calling udm')
-             ENDIF
-


should not remove these lines.

weiwangncar · 2025-11-20T12:11:49Z

@BarryHLynn The general errors you made is to overwrite the current version of the code with the version you worked on. Doing so, you removed many new updates we made in the model (which I pointed out). Those changes are not part of the modification you intend to make, and should be removed / corrected for this PR.

BarryHLynn · 2025-11-20T12:25:54Z

Hi: I am not sure how this happened. I downloaded the code a while back (but not too long ago) and made changes only to solve_em.F by passing some variables to the microphysical driver, and added three subroutine calls to the driver. I am not sure how to address any of the other issues because I had trouble downloading a clean version from the web again. I can't compile on a node that has access to the web and the extra pull did not solve the problem with missing code. I indicated which routines I added and which were modified. That is all that has to be done. Barry

…

On Thu, Nov 20, 2025 at 2:12 PM weiwangncar ***@***.***> wrote: *weiwangncar* left a comment (wrf-model/WRF#2258) <#2258 (comment)> @BarryHLynn <https://github.com/BarryHLynn> The general errors you made is to overwrite the current version of the code with the version you worked on. Doing so, you removed many new updates we made in the model (which I pointed out). Those changes are not part of the modification you intend to make, and should be removed / corrected for this PR. — Reply to this email directly, view it on GitHub <#2258 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKWLWRXKGQSCCFXYGZSPL4335WVZZAVCNFSM6AAAAACK5MMZMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNJXGY4TONRZGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Barry H. Lynn, Ph.D Senior Scientist, Lecturer, The Institute of Earth Sciences, The Hebrew University of Jerusalem, Givat Ram, Jerusalem 91904, Israel Tel: 972 547 231 170 Fax: (972)-25662581 Weather It Is, LTD Weather and Climate Focus https://weather-it-is.com <http://weather-it-is.com> Jerusalem, Israel Local: 02 930 9525 Cell: 054 7 231 170 Int-IS: x972 2 930 9525

dudhia · 2025-11-20T18:21:21Z

In github one thing not to do is copy modules from another directory into the one you downloaded. You should only clone an existing recent release version and edit that directly.

Dynamic Lightning (LPI): Registry/driver/lightning updates only

739849d

BarryHLynn requested review from a team as code owners November 2, 2025 18:46

Return l_obs to Registry for future use

47d5b98

weiwangncar reviewed Nov 20, 2025

View reviewed changes

phys/Makefile

else \

echo No action required for MYNN-EDMF submodule ; \

fi

Copy link

Collaborator

weiwangncar Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not remove these lines either.

weiwangncar reviewed Nov 20, 2025

View reviewed changes

Dynamic Lightning (LPI): Registry/driver/lightning updates only #2258

Are you sure you want to change the base?

Dynamic Lightning (LPI): Registry/driver/lightning updates only #2258

Uh oh!

Conversation

BarryHLynn commented Nov 2, 2025

Uh oh!

BarryHLynn commented Nov 2, 2025

Uh oh!

dudhia commented Nov 3, 2025

Uh oh!

BarryHLynn commented Nov 3, 2025 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weiwangncar commented Nov 20, 2025

Uh oh!

BarryHLynn commented Nov 20, 2025 via email

Uh oh!

dudhia commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants