[TM-2478] Polygon Size and Estimated Area validators #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated-area-validators
…te-validators' into feat/TM-2478-polygon-size-estimated-area-validators
…te-validators' into feat/TM-2478-polygon-size-estimated-area-validators
…te-validators' into feat/TM-2478-polygon-size-estimated-area-validators
…te-validators' into feat/TM-2478-polygon-size-estimated-area-validators
Base automatically changed from
feat/TM-2489-complete-data-and-plant-start-date-validators
to
release/opulent-opal
September 30, 2025 14:25
roguenet
reviewed
Oct 1, 2025
| lowerBoundProject: number | null; | ||
| upperBoundProject: number | null; | ||
| }> { | ||
| const site = sitePolygon.site != null ? sitePolygon.site : await sitePolygon.loadSite(); |
There was a problem hiding this comment.
The loadSite method does these checks for you, so this can simply be
const site = await sitePolygon.loadSite();
If it's already been loaded, it'll return immediately.
There was a problem hiding this comment.
Fixed redundant null check for loadSite() method.
| const siteUuids = sites.map(site => site.uuid); | ||
| const result = await SitePolygon.sum("calcArea", { | ||
| where: { | ||
| siteUuid: siteUuids, |
There was a problem hiding this comment.
This should be handled with a subquery instead of the findAll above. Should this be using only approved sites? If so, there's one already ready for you to use (approvedUuidsSubquery). If not, you can add this to Site and use it:
static uuidsSubquery(projectId: number) {
return Subquery.select(Site, "uuid").eq("projectId", projectId).literal;
}
There was a problem hiding this comment.
Added uuidsSubquery method to the Site entity.
roguenet
approved these changes
Oct 1, 2025
cesarLima1
deleted the
feat/TM-2478-polygon-size-estimated-area-validators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gfw.atlassian.net/browse/TM-2478