Improve Comments Section #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle comment section stream with StreamController. StreamSubscription pauses the stream initially, while the StreamController is used to add the comment section data in until the user scrolls to the bottom of the screen. Also added a small margin bottom to comments to even out the spaces between each item.
|
Thanks for your PR @adhamjongsma ❤️ !! I'm a bit busy this week -- but I'll make sure to review it before the week ends. In the meantime I triggered the build pipeline so I can functionally test the changed 😁 |
|
Yeah! There's no rush. Was just fun getting to grips with flutter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Wessel, this draft PR is almost done!
So I feel the need to pontificate that I'm not 100% sure this is the most elegant solution. This is my first foray into Dart.
So, for the lazy loading mechanism I did some reading on the Dart concept of streams and I basically setup a
StreamControllerto manage adding the stream result manually, while I use theStreamSubscriptionto pause and resume the stream when the user scrolls far enough into view.I didn't see any overlapping comments, oddly. Maybe there's a flutter SDK version issue here, but I did add a small amount of margin to all the comments in order to even out the spaces. Let me know what you think?
Note: I still need to edit some bits of this, for example, it will continue to try and load comments even when you scroll to the end, but I'll do that one evening next week. I just wanted to show you what I have so far just so you can either tell me that it looks good or that I need to start all over again lol.