Adding domain check to mitigate SSRF attacks. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PasinduYeshan
commented
Aug 11, 2022
•
PasinduYeshan
commented
- When device information is requested from Entgra if the device is not enrolled it returns 404. That error checking is added to this PR.
- Added domain check before sending HTTP requests.
PasinduYeshan
changed the title
ashendes
reviewed
Aug 22, 2022
| if (domain != null) { | ||
| domainArr = StringUtils.split(domain, DOMAIN_SEPARATOR); | ||
| if (domainArr.length != 0) { | ||
| parentDomain = domainArr.length == 1 ? domainArr[0] : domainArr[domainArr.length - 2]; |
There was a problem hiding this comment.
Parent domain should be the joined string of the last two elements.
ashendes
reviewed
Aug 22, 2022
| * @param url | ||
| * @return validity | ||
| */ | ||
| private boolean isValidRequestDomain(URI url) { |
There was a problem hiding this comment.
Isn't there any Framework util method for this?
There was a problem hiding this comment.
I got this from the http conditional auth function. It was implemented as a private method and I didn't find any util method for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.